Hi Hans,
On Tue, Apr 21, 2015 at 5:32 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>> diff --git a/drivers/media/usb/gspca/sn9c2028.h
>> b/drivers/media/usb/gspca/sn9c2028.h
>> index 8fd1d3e..6f20c0f 100644
>> --- a/drivers/media/usb/gspca/sn9c2028.h
>> +++ b/drivers/media/usb/gspca/sn9c2028.h
>> @@ -21,8 +21,17 @@
>> *
>> */
>>
>> -static const unsigned char sn9c2028_sof_marker[5] =
>> - { 0xff, 0xff, 0x00, 0xc4, 0xc4 };
>> +static const unsigned char sn9c2028_sof_marker[] = {
>> + 0xff, 0xff, 0x00, 0xc4, 0xc4, 0x96,
>> + 0x00,
>> + 0x00, /* seq */
>> + 0x00,
>> + 0x00,
>> + 0x00, /* avg luminance lower 8 bit */
>> + 0x00, /* avg luminance higher 8 bit */
>> + 0x00,
>> + 0x00,
>> +};
>>
>
> This seems wrong, the header is only 12 bytes the extra 2 0x00 bytes you add
> are
> actually part of the compressed data and are parsed by the userspace code,
> please drop them.
OK, I've found average lumimance value in header heuristically,
based on info that it's present in header of sn9c1xx and sn9c201 cams,
and I didn't check actual header length - my fault.
Regards,
Vasily
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
