Hi Prabhakar,
Thank you for the review.
On Fri, Apr 10, 2015 at 10:54:08PM +0100, Lad, Prabhakar wrote:
> Hi Sakari,
>
> Thanks for the patch.
>
> On Thu, Apr 9, 2015 at 10:25 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> > Instead of parsing the link-frequencies property in the driver, let
> > v4l2_of_alloc_parse_endpoint() do it.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/media/i2c/smiapp/smiapp-core.c | 40 ++++++++++++++++----------------
> > 1 file changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
> > index 557f25d..4a2e8d3 100644
> > --- a/drivers/media/i2c/smiapp/smiapp-core.c
> > +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> > @@ -2975,9 +2975,9 @@ static int smiapp_resume(struct device *dev)
> > static struct smiapp_platform_data *smiapp_get_pdata(struct device *dev)
> > {
> > struct smiapp_platform_data *pdata;
> > - struct v4l2_of_endpoint bus_cfg;
> > + struct v4l2_of_endpoint *bus_cfg;
> > struct device_node *ep;
> > - uint32_t asize;
> > + int i;
> > int rval;
> >
> > if (!dev->of_node)
> > @@ -2987,13 +2987,17 @@ static struct smiapp_platform_data *smiapp_get_pdata(struct device *dev)
> > if (!ep)
> > return NULL;
> >
> > + bus_cfg = v4l2_of_alloc_parse_endpoint(ep);
> > + if (IS_ERR(bus_cfg)) {
> > + rval = PTR_ERR(bus_cfg);
>
> this assignment is not required.
>
> Apart from that the patch looks good.
>
> Reviewed-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
Good point. I'll remove it.
There's another case of the same in the function, I'll send a separate patch
on that. I'll send a pull request on these soonish.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
