Hi Laurent, On Tue, Apr 07, 2015 at 01:11:34PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Tuesday 07 April 2015 01:57:29 Sakari Ailus wrote: > > The field is unused. Remove it. > > Do you know what the field was added for in the first place ? Frankly I have to admit I have no idea. It's part of the original patch which adds V4L2 OF support: --- commit 99fd133f907afdb430942d8d2ae53faa438adfe8 Author: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> Date: Wed Sep 26 05:24:03 2012 -0300 [media] Add a V4L2 OF parser Add a V4L2 OF parser, implementing bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. [s.nawrocki@xxxxxxxxxxx: various corrections and improvements since the initial version] Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> --- It looks like the intent has been that the field is used in order to keep a list of structs of this kind, but no-one is using it for that purpose at the moment. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html