Hi Kassey, Thanks for updating your patch and addressing my comments! In your reply to v1 of this patch you said, that you would add DT support in v2, i.e. in this version, right? Is it now present in this patch? If yes - can you explain to me how it works? For I2C the soc_camera_host_register() function calls scan_of_host() always when an OF node is present in the camera hostdevice, i.e. it would also be called in your SPI case, but the soc_of_bind() function, called there, explicitly uses I2C binding, so, it won't work for SPI. Could you explain? Besides, you place your SPI support functions under #ifdef CONFIG_I2C_BOARDINFO, which doesn't make much sense for SPI. Thanks Guennadi On Mon, 2 Feb 2015, Kassey Li wrote: > From: Kassey Li <kasseyl@xxxxxxxxxx> > > This adds support for spi interface sub device for > soc_camera. > > Signed-off-by: Kassey Li <kasseyl@xxxxxxxxxx> > --- > drivers/media/platform/soc_camera/soc_camera.c | 94 ++++++++++++++++++++++++ > include/media/soc_camera.h | 4 + > 2 files changed, 98 insertions(+) [patch omitted] -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
