Hi Philipp, Thank you for the review. On Tuesday 31 March 2015 17:08:53 Philipp Zabel wrote: > Am Mittwoch, den 18.03.2015, 15:38 +0200 schrieb Laurent Pinchart: > > Parse DT properties into a platform data structure when a DT node is > > available. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > --- > > > > Changes since v3: > > > > - Use /bits/ 64 in the DT bindings example > > - Remove the parent I2C master node from the DT bindings example > > - Use devm_kcalloc() to allocate array > > > > Changes since v2: > > > > - Use of_graph_get_next_endpoint() > > > > Changes since v1: > > > > - Add MT9V02[24] compatible strings > > - Prefix all compatible strings with "aptina," > > - Use "link-frequencies" instead of "link-freqs" > > --- > > > > .../devicetree/bindings/media/i2c/mt9v032.txt | 39 ++++++++++++ > > MAINTAINERS | 1 + > > drivers/media/i2c/mt9v032.c | 69 ++++++++++++++++- > > 3 files changed, 108 insertions(+), 1 deletion(-) > > create mode 100644 > > Documentation/devicetree/bindings/media/i2c/mt9v032.txt [snip] > > diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c > > index 255ea91..697be25 100644 > > --- a/drivers/media/i2c/mt9v032.c > > +++ b/drivers/media/i2c/mt9v032.c > > @@ -17,6 +17,8 @@ > > #include <linux/i2c.h> > > #include <linux/log2.h> > > #include <linux/mutex.h> > > +#include <linux/of.h> > > +#include <linux/of_gpio.h> > > I think of_gpio is not needed in mt9v032.c. Otherwise, > Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> You're right. The bad news is that the patch has been merged already. The good news is that you can submit a patch to fix this ;-) I can also fix it myself if you prefer. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
