On 20/03/15 9:39 pm, "Hans Verkuil" <hverkuil@xxxxxxxxx> wrote:
>Hi Prashant,
>
>> +
>> + h_freq = (u32)bt->pixelclock / total_h_pixel;
>> +
>> + if (bt->standards == V4L2_DV_BT_STD_CVT)
>
>This test and the next isn't right. Apologies that I didn't see that
>when I reviewed v1.
>
>The correct test is:
>
> if (bt->standard == 0 || (bt->standards & V4L2_DV_BT_STD_CVT))
>
>
>> + return v4l2_detect_cvt(total_v_lines, h_freq, bt->vsync,
>> + bt->polarities, timings);
>
>Just returning here isn't right either: if a CVT format is detected, then
>it can return true, otherwise it should continue and try the GTF format.
>
>> +
>> + if (bt->standards == V4L2_DV_BT_STD_GTF) {
>
>And this becomes:
>
> If (bt->standard == 0 || (bt->standards & V4L2_DV_BT_STD_GTF))
>
>When it comes to autodetecting formats the driver can often detect
>only a few timing properties, and it is rarely able to say if it
>will be a CVT or GTF timing. So often they leave bt->standard to 0.
>
Thanks Hans. I will fix it and post v3.
Regards,
Prashant
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
