Hello Hans,
Thanks for reviewing the patch.
On 20/03/15 5:00 pm, "Hans Verkuil" <hverkuil@xxxxxxxxx> wrote:
>
>> + if (cvt->interlaced == V4L2_DV_INTERLACED) {
>> + cvt->il_vfrontporch = v_fp;
>> + cvt->il_vsync = v_sync;
>> + cvt->il_vbackporch = v_bp;
>> + /* For interlaced format, add half lines to front and back
>> + * porches of odd and even fields respectively */
>> + cvt->flags |= V4L2_DV_FL_HALF_LINE;
>> + cvt->vfrontporch += 1;
>> + cvt->il_vbackporch += 1;
>
>This isn't right, you should do the +1 only for the il_vbackporch.
>Otherwise
>V4L2_DV_BT_FRAME_HEIGHT(bt) would be one too big.
>
>The HALF_LINE flag means that, if drivers support it, they can add a
>half-line
>to the vfrontporch of the odd field and subtract a half-line for the
>vbackporch
>of the even field.
>
>BTW, the V4L2_DV_FL_HALF_LINE documentation in the spec should be
>improved to
>state the above. Right now it doesn't specify to which porch the
>half-lines go.
>
>This same bug is in the detect_gtf function.
Will fix this bug and resubmit the patch.
Regards,
Prashany
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
