Re: [PATCH 1/5] media/v4l2-ctrls: volatiles should not generate CH_VALUE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ricardo Ribalda Delgado wrote:
Volatile controls should not generate CH_VALUE events.

Set has_changed to false to prevent this happening.

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
---
  drivers/media/v4l2-core/v4l2-ctrls.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
index 45c5b47..627d4c7 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -1609,6 +1609,15 @@ static int cluster_changed(struct v4l2_ctrl *master)

  		if (ctrl == NULL)
  			continue;
+                /*
+                 * Set has_changed to false to avoid generating
+                 * the event V4L2_EVENT_CTRL_CH_VALUE
+                 */

Tabs for indentation, please.

+		if (ctrl->flags & V4L2_CTRL_FLAG_VOLATILE){

s/){/) {/

+                       ctrl->has_changed = false;
+		       continue;
+		}
+
  		for (idx = 0; !ctrl_changed && idx < ctrl->elems; idx++)
  			ctrl_changed = !ctrl->type_ops->equal(ctrl, idx,
  				ctrl->p_cur, ctrl->p_new);



--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux