Hi Sakari,
Thank you for the patch.
On Tuesday 10 March 2015 03:18:00 Sakari Ailus wrote:
> Don't set rval when it's not used (the function returns a pointer to struct
> smiapp_platform_data).
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/smiapp/smiapp-core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
> b/drivers/media/i2c/smiapp/smiapp-core.c index b1f566b..565a00c 100644
> --- a/drivers/media/i2c/smiapp/smiapp-core.c
> +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> @@ -2988,10 +2988,8 @@ static struct smiapp_platform_data
> *smiapp_get_pdata(struct device *dev) return NULL;
>
> pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> - if (!pdata) {
> - rval = -ENOMEM;
> + if (!pdata)
> goto out_err;
> - }
>
> v4l2_of_parse_endpoint(ep, &bus_cfg);
>
> @@ -3001,7 +2999,6 @@ static struct smiapp_platform_data
> *smiapp_get_pdata(struct device *dev) break;
> /* FIXME: add CCP2 support. */
> default:
> - rval = -EINVAL;
> goto out_err;
> }
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
