Re: [PATCH 00/18] marvell-ccic + ov7670 fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon,  9 Mar 2015 22:22:05 +0100
Hans Verkuil <hverkuil@xxxxxxxxx> wrote:

> This patch series makes loads of fixes and improvements to the marvell-ccic
> and ov7670 drivers. This has been tested on an OLPC XO-1 laptop.

So I'm traveling and even shorter on time than usual.  I've had a quick
look over these patches, and they generally seem OK.  Just don't ding me
for not using a bunch of infrastructure that wasn't there when I wrote
this thing! :)

Ideally it would be nice to see patch 9 split - locking changes separate
from use of helpers - but that's a quibble.

Out of curiosity, is there a use driving this work, or are you just
making things cleaner?

Regardless, it clearly improves the drivers; thanks for doing this.

Acked-by: Jonathan Corbet <corbet@xxxxxxx>

> I do need to check the last patch with Libin Yang since his patch from mid-2013
> broke the driver for the OLPC laptop. Nobody noticed since the latest released
> kernel from the OLPC project for that laptop is 3.3, which didn't have his patch.

Libin seems to have vanished, and I think that whatever interest Marvell
had in supporting this driver has vanished with him, unfortunately.  I'm
still tempted to revert much of that work, since I'm not sure it has ever
worked on a real system...

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux