[PATCH 0/4] soc-camera: Make clock start and stop operations optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

This patch set makes the soc-camera host clock_start and clock_stop operations
optional and remove the empty stubs from the rcar-vin driver.

The rationale behind the change is that clock_start and clock_stop are
supposed to control a clock output supplied to the sensor, exposed through a
v4l2 clock. While some drivers abuse it to start/stop video streaming on the
host side and should be fixed, other drivers that behave correctly currently
have to implement stubs if the video hardware doesn't have a clock output.

The last patch in the series skips v4l2 clock registration completely if the
clock operations are not provided, as that v4l2 clock is a no-op. This could
introduce breakage and thus needs to be reviewed and tested carefully. I've
included the patch last to make it easy to skip it for now and only apply the
rest.

Laurent Pinchart (4):
  soc-camera: Unregister v4l2 clock in the OF bind error path
  soc-camera: Make clock_start and clock_stop operations optional
  rcar-vin: Don't implement empty optional clock operations
  soc-camera: Skip v4l2 clock registration if host doesn't provide clk
    ops

 drivers/media/platform/soc_camera/rcar_vin.c   |  15 ----
 drivers/media/platform/soc_camera/soc_camera.c | 113 +++++++++++++++----------
 2 files changed, 67 insertions(+), 61 deletions(-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux