Re: [GIT PULL for v4.1] smiapp DT u64 property workaround removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

On Sunday 08 March 2015 01:20:40 Sakari Ailus wrote:
> On Sun, Mar 08, 2015 at 01:15:38AM +0200, Laurent Pinchart wrote:
> > > Sakari Ailus (2):
> > >       Revert "[media] smiapp: Don't compile of_read_number() if
> > >       CONFIG_OF isn't defined"
> > >       smiapp: Use of_property_read_u64_array() to read a 64-bit number
> > >       array
> > 
> > Won't this cause a bisection breakage if CONFIG_OF isn't enabled ?
> 
> Technically you're right: it does "break" bisect if smiapp is compiled in on
> a non-DT platform. Such a platform is not supported in a mainline kernel so
> I don't think this is a really major issue.
> 
> I could combine the patches if you think this is an issue.

It would break bisection with allmodconfig on non-DT platforms for instance. I 
think combining the two patches would make sense.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux