Em Mon, 02 Feb 2015 12:22:32 +0300 Kozlov Sergey <serjk@xxxxxxxx> escreveu: > > DVB SEC frontend driver for STM LNBH25PQR chip. > > Signed-off-by: Kozlov Sergey <serjk@xxxxxxxx> > --- > MAINTAINERS | 9 ++ > drivers/media/dvb-frontends/Kconfig | 8 ++ > drivers/media/dvb-frontends/Makefile | 1 + > drivers/media/dvb-frontends/lnbh25.c | 182 ++++++++++++++++++++++++++++++++++ > drivers/media/dvb-frontends/lnbh25.h | 56 +++++++++++ > 5 files changed, 256 insertions(+) > create mode 100644 drivers/media/dvb-frontends/lnbh25.c > create mode 100644 drivers/media/dvb-frontends/lnbh25.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index a022d6d..8a687dc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5853,6 +5853,15 @@ Q: http://patchwork.linuxtv.org/project/linux-media/list/ > S: Maintained > F: drivers/media/usb/dvb-usb-v2/lmedm04* > > +LNBH25 MEDIA DRIVER Same note here with regards to the name: MEDIA DRIVERS FOR LNBH25 > +M: Sergey Kozlov <serjk@xxxxxxxx> > +L: linux-media@xxxxxxxxxxxxxxx > +W: http://linuxtv.org/ > +W: http://netup.tv/ > +T: git git://linuxtv.org/media_tree.git > +S: Supported > +F: drivers/media/dvb-frontends/lnbh25* > + > LOCKDEP AND LOCKSTAT > M: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > M: Ingo Molnar <mingo@xxxxxxxxxx> > diff --git a/drivers/media/dvb-frontends/Kconfig b/drivers/media/dvb-frontends/Kconfig > index c94bb7b..b3b216d 100644 > --- a/drivers/media/dvb-frontends/Kconfig > +++ b/drivers/media/dvb-frontends/Kconfig > @@ -693,6 +693,14 @@ comment "SEC control devices for DVB-S" > > source "drivers/media/dvb-frontends/drx39xyj/Kconfig" > > +config DVB_LNBH25 > + tristate "LNBH25 SEC controller" > + depends on DVB_CORE && I2C > + default m if !MEDIA_SUBDRV_AUTOSELECT > + help > + An SEC control chip. > + Say Y when you want to support this chip. > + > config DVB_LNBP21 > tristate "LNBP21/LNBH24 SEC controllers" > depends on DVB_CORE && I2C > diff --git a/drivers/media/dvb-frontends/Makefile b/drivers/media/dvb-frontends/Makefile > index 0b19c10..06a0d21 100644 > --- a/drivers/media/dvb-frontends/Makefile > +++ b/drivers/media/dvb-frontends/Makefile > @@ -56,6 +56,7 @@ obj-$(CONFIG_DVB_LGDT330X) += lgdt330x.o > obj-$(CONFIG_DVB_LGDT3305) += lgdt3305.o > obj-$(CONFIG_DVB_LG2160) += lg2160.o > obj-$(CONFIG_DVB_CX24123) += cx24123.o > +obj-$(CONFIG_DVB_LNBH25) += lnbh25.o > obj-$(CONFIG_DVB_LNBP21) += lnbp21.o > obj-$(CONFIG_DVB_LNBP22) += lnbp22.o > obj-$(CONFIG_DVB_ISL6405) += isl6405.o > diff --git a/drivers/media/dvb-frontends/lnbh25.c b/drivers/media/dvb-frontends/lnbh25.c > new file mode 100644 > index 0000000..fcefc66 > --- /dev/null > +++ b/drivers/media/dvb-frontends/lnbh25.c > @@ -0,0 +1,182 @@ > +/* > + * lnbh25.c > + * > + * Driver for LNB supply and control IC LNBH25 > + * > + * Copyright (C) 2014 NetUP Inc. > + * Copyright (C) 2014 Sergey Kozlov <serjk@xxxxxxxx> > + * Copyright (C) 2014 Abylay Ospan <aospan@xxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include <linux/module.h> > +#include <linux/init.h> > +#include <linux/string.h> > +#include <linux/slab.h> > + > +#include "dvb_frontend.h" > +#include "lnbh25.h" > + > +static int debug; > + > +#define dprintk(args...) \ > + do { \ > + if (debug) \ > + dev_dbg(&priv->i2c->dev, args); \ > + } while (0) This is not very nice, as, in order to enable debug, both this parameter and dynamic printk should be enabled via /sys/kernel/debug/dynamic_debug. Just use dev_dbg() directly. > + > +struct lnbh25_priv { > + struct i2c_adapter *i2c; > + u8 i2c_address; > + /* > + * LNBH25 configuration: > + * offset 0: first LNBH25 register address: always 0x02 (DATA1) > + * offset 1: DATA1 register value > + * offset 2: DATA2 register value > + */ > + u8 config[3]; > +}; Please use Documentation/kernel-doc-nano-HOWTO.txt format. > + > +#define LNBH25_STATUS_OFL 0x1 > +#define LNBH25_STATUS_VMON 0x4 > +#define LNBH25_VSEL_13 0x03 > +#define LNBH25_VSEL_18 0x0a > + > +static void lnbh25_read_vmon(struct lnbh25_priv *priv) > +{ > + int i; > + u8 addr = 0x00; > + u8 status[6]; > + struct i2c_msg msg[2] = { > + { > + .addr = priv->i2c_address, > + .flags = 0, > + .len = 1, > + .buf = &addr > + }, { > + .addr = priv->i2c_address, > + .flags = I2C_M_RD, > + .len = sizeof(status), > + .buf = status > + } > + }; > + > + msleep(100); That looks weird: starting the code with a sleep. I suspect that this is misplaced. You're already sleeping for 20 ms before calling this function, at lnbh25_set_voltage(). I suspect that the best would be to remove this and to change the wait time for the voltage to stabilize at lnbh25_set_voltage() to 120 ms. > + for (i = 0; i < 2; i++) { > + if (i2c_transfer(priv->i2c, &msg[i], 1) != 1) { > + dprintk("%s(): I2C transfer %d failed\n", > + __func__, i); > + return; It would be better to return an error code here. > + } > + } > + for (i = 0; i < sizeof(status); i++) > + dprintk("%s(): reg %d value 0x%x\n", > + __func__, i, (int)status[i]); > + if ((status[0] & (LNBH25_STATUS_OFL | LNBH25_STATUS_VMON)) != 0) > + dev_err(&priv->i2c->dev, > + "%s(): voltage in failure state, status reg 0x%x\n", > + __func__, status[0]); > +} > + > +static int lnbh25_set_voltage(struct dvb_frontend *fe, > + fe_sec_voltage_t voltage) > +{ > + u8 data1_reg; > + const char *vsel; > + struct lnbh25_priv *priv = fe->sec_priv; > + struct i2c_msg msg = { > + .addr = priv->i2c_address, > + .flags = 0, > + .len = sizeof(priv->config), > + .buf = priv->config > + }; > + > + switch (voltage) { > + case SEC_VOLTAGE_OFF: > + data1_reg = 0x00; > + vsel = "Off"; > + break; > + case SEC_VOLTAGE_13: > + data1_reg = LNBH25_VSEL_13; > + vsel = "13V"; > + break; > + case SEC_VOLTAGE_18: > + data1_reg = LNBH25_VSEL_18; > + vsel = "18V"; > + break; > + default: > + return -EINVAL; > + } > + priv->config[1] = data1_reg; > + dprintk("%s(): %s, I2C 0x%x write [ %02x %02x %02x ]\n", > + __func__, vsel, priv->i2c_address, > + priv->config[0], priv->config[1], priv->config[2]); > + if (i2c_transfer(priv->i2c, &msg, 1) != 1) { > + dev_err(&priv->i2c->dev, > + "%s(): I2C transfer error\n", __func__); > + return -EIO; Please return the error code that i2c_transfer() returns, instead of -EIO. > + } > + msleep(20); > + if (voltage != SEC_VOLTAGE_OFF) > + lnbh25_read_vmon(priv); As said before, assuming that those msleep() are required, it seems that the right thing to do here would be, instead: if (voltage != SEC_VOLTAGE_OFF) { msleep(120); lnbh25_read_vmon(priv); } else { msleep(20); } and remove that weird msleep(100) from lnbh25_read_vmon(). > + return 0; > +} > + > +static void lnbh25_release(struct dvb_frontend *fe) > +{ > + struct lnbh25_priv *priv = fe->sec_priv; > + > + dprintk("%s()\n", __func__); > + lnbh25_set_voltage(fe, SEC_VOLTAGE_OFF); > + kfree(fe->sec_priv); > + fe->sec_priv = NULL; > +} > + > +struct dvb_frontend *lnbh25_attach( > + struct dvb_frontend *fe, > + struct lnbh25_config *cfg, > + struct i2c_adapter *i2c) Just identation. It is better to declare as: struct dvb_frontend *lnbh25_attach(struct dvb_frontend *fe, struct lnbh25_config *cfg, struct i2c_adapter *i2c) > +{ > + struct lnbh25_priv *priv; > + > + dprintk("%s()\n", __func__); > + priv = kzalloc(sizeof(struct lnbh25_priv), GFP_KERNEL); > + if (!priv) > + return NULL; > + priv->i2c_address = (cfg->i2c_address >> 1); > + priv->i2c = i2c; > + priv->config[0] = 0x02; > + priv->config[1] = 0x00; > + priv->config[2] = cfg->data2_config; > + fe->sec_priv = priv; > + if (lnbh25_set_voltage(fe, SEC_VOLTAGE_OFF)) { > + dev_err(&i2c->dev, "%s(): no LNBH25 found at I2C addr 0x%02x\n", > + __func__, priv->i2c_address); > + kfree(priv); > + fe->sec_priv = NULL; > + return NULL; > + } > + > + fe->ops.release_sec = lnbh25_release; > + fe->ops.set_voltage = lnbh25_set_voltage; > + > + dev_err(&i2c->dev, "%s(): attached at I2C addr 0x%02x\n", > + __func__, priv->i2c_address); > + return fe; > +} > +EXPORT_SYMBOL(lnbh25_attach); > + > +module_param(debug, int, 0644); > +MODULE_DESCRIPTION("ST LNBH25 driver"); > +MODULE_AUTHOR("info@xxxxxxxx"); > +MODULE_LICENSE("GPL"); > + > diff --git a/drivers/media/dvb-frontends/lnbh25.h b/drivers/media/dvb-frontends/lnbh25.h > new file mode 100644 > index 0000000..7fc5123 > --- /dev/null > +++ b/drivers/media/dvb-frontends/lnbh25.h > @@ -0,0 +1,56 @@ > +/* > + * lnbh25.c > + * > + * Driver for LNB supply and control IC LNBH25 > + * > + * Copyright (C) 2014 NetUP Inc. > + * Copyright (C) 2014 Sergey Kozlov <serjk@xxxxxxxx> > + * Copyright (C) 2014 Abylay Ospan <aospan@xxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#ifndef LNBH25_H > +#define LNBH25_H > + > +#include <linux/i2c.h> > +#include <linux/kconfig.h> > +#include <linux/dvb/frontend.h> > + > +/* 22 kHz tone enabled. Tone output controlled by DSQIN pin */ > +#define LNBH25_TEN 0x01 > +/* Low power mode activated (used only with 22 kHz tone output disabled) */ > +#define LNBH25_LPM 0x02 > +/* DSQIN input pin is set to receive external 22 kHz TTL signal source */ > +#define LNBH25_EXTM 0x04 > + > +struct lnbh25_config { > + u8 i2c_address; > + u8 data2_config; > +}; > + > +#if IS_ENABLED(CONFIG_DVB_LNBH25) > +struct dvb_frontend *lnbh25_attach( > + struct dvb_frontend *fe, > + struct lnbh25_config *cfg, > + struct i2c_adapter *i2c); > +#else > +static inline dvb_frontend *lnbh25_attach( > + struct dvb_frontend *fe, > + struct lnbh25_config *cfg, > + struct i2c_adapter *i2c) > +{ > + printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__); > + return NULL; > +} > +#endif > + > +#endif -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
