On 04/03/15 10:47, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > If a subdevice pad op is called from a bridge driver, then there is > no v4l2_subdev_fh struct that can be passed to the subdevice. This > made it hard to use such subdevs from a bridge driver. > > This patch replaces the v4l2_subdev_fh pointer by a v4l2_subdev_pad_config > pointer in the pad ops. This allows bridge drivers to use the various > try_ pad ops by creating a v4l2_subdev_pad_config struct and passing it > along to the pad op. > > The v4l2_subdev_get_try_* macros had to be changed because of this, so > I also took the opportunity to use the full name of the v4l2_subdev_get_try_* > functions in the __V4L2_SUBDEV_MK_GET_TRY macro arguments: if you now do > 'git grep v4l2_subdev_get_try_format' you will actually find the header > where it is defined. > > One remark regarding the drivers/staging/media/davinci_vpfe patches: the > *_init_formats() functions assumed that fh could be NULL. However, that's > not true for this driver, it's always set. This is almost certainly a copy > and paste from the omap3isp driver. I've updated the code to reflect the > fact that fh is never NULL. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> > Tested-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> For: > drivers/media/i2c/m5mols/m5mols_core.c | 16 ++--- > drivers/media/i2c/noon010pc30.c | 17 ++--- > drivers/media/i2c/ov9650.c | 16 ++--- > drivers/media/i2c/s5c73m3/s5c73m3-core.c | 51 +++++++------- > drivers/media/i2c/s5k4ecgx.c | 16 ++--- > drivers/media/i2c/s5k5baf.c | 38 +++++----- > drivers/media/i2c/s5k6a3.c | 18 ++--- > drivers/media/i2c/s5k6aa.c | 34 ++++----- > drivers/media/platform/exynos4-is/fimc-capture.c | 22 +++--- > drivers/media/platform/exynos4-is/fimc-isp.c | 28 ++++---- > drivers/media/platform/exynos4-is/fimc-lite.c | 33 ++++----- > drivers/media/platform/exynos4-is/mipi-csis.c | 16 ++--- > drivers/media/platform/s3c-camif/camif-capture.c | 18 ++--- > drivers/media/v4l2-core/v4l2-subdev.c | 18 ++--- > include/media/v4l2-subdev.h | 53 ++++++++------ Acked-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> -- Sylwester Nawrocki Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
