On Mon, Mar 2, 2015 at 6:46 PM, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Mon, Mar 02, 2015 at 06:22:31PM +0100, Geert Uytterhoeven wrote: >> On Mon, Mar 2, 2015 at 6:06 PM, Russell King >> <rmk+kernel@xxxxxxxxxxxxxxxx> wrote: >> > --- a/include/linux/clkdev.h >> > +++ b/include/linux/clkdev.h >> > @@ -37,6 +37,9 @@ struct clk_lookup *clkdev_alloc(struct clk *clk, const char *con_id, >> > void clkdev_add(struct clk_lookup *cl); >> > void clkdev_drop(struct clk_lookup *cl); >> > >> > +struct clk_lookup *clkdev_create(struct clk *clk, const char *con_id, >> > + const char *dev_fmt, ...); >> >> __printf(3, 4) >> >> While you're at it, can you please also add the __printf attribute to >> clkdev_alloc() and clk_register_clkdev()? > > What's the behaviour of __printf() with a NULL format string? The > clkdev interfaces permit that, normal printf() doesn't. As expected: no warning. Verified with gcc 4.1.2 and 4.8.2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html