Re: [PATCH] [media] saa7164: use an MSI interrupt when available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I believe the root cause of the crash is due to a DMA/IRQ race condition. It
> most commonly occurs when the saa7164 driver is dealing with more than one
> saa7164 chip (the HVR-2200 and HVR-2250 for example have two - one for each
> tuner). Given MSI avoids DMA/IRQ race conditions - this would explain why
> the patch works as a fix.

Brendan, thanks.

With MSI I've had some people report complete success, others still
have the issues.

In my experience this does help with i2c timeout issues but not
completely in every case. I've also seen it with single card instances
so you descripton above is close - but not quiet accurate in all
cases.

While I'm generally OK with changing the driver behaviour to enable
MSI by default, please add a module option to allow the behaviour to
be disabled, reverting the driver back to existing behaviour.

Once this is done, I'll be happy to Ack it.

Thanks again.

- Steve

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux