On 02/25/2015 07:56 PM, Devin Heitmueller wrote:
I would request you to add a comment here indicating the
hybrid case scenario to avoid any future cleanup type work
deciding there is no need to set priv->firmware to null
since priv gets released in hybrid_tuner_release_state(priv);
No, I'm not going to rebase my tree and regenerate the patch just to
add a comment explaining how hybrid_tuner_[request/release]_state()
works (which, btw, is how it works in all hybrid tuner drivers). I
already wasted enough of my time tracking down the source of the
memory corruption and providing a fix for this regression. If you
want to submit a subsequent patch with a comment, be my guest.
These are just the issues I would like to implement drivers as standard
I2C driver model =) Attaching driver for one chip twice is ugly hack!
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
