Hi Hans, go for it if you feel it's the best approach. Are you planning to add multiplanar formats? Particularly, I'm interested in YUV420M and its twin evil brother YVU420M. I would recommend adding support for a less-common format such as YUV410 (or variation thereof). Since this format is so different, it stresses the added code in revealing ways. I was planning to support it as a bonus, but I noticed is not recognised in lib4vl -- neither in qv4l2, therefore. Just saying, it'd be cool. Cheers M On 24 February 2015 at 00:02, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > Hi Miguel, > > Thanks for the patch. However, after reviewing it and testing it > I decided to implement my own version. Partially because several > features were still failing (crop/compose/scale), partially because > I didn't like the way the tpg was changed: too much change basically. > > Yesterday I added YUV 420 support. It's still work in progress as I > am not happy with some of the internal changes and because changing the > compose height fails to work at the moment. > > You can find my preliminary work here: > > http://git.linuxtv.org/cgit.cgi/hverkuil/media_tree.git/log/?h=vivid-420 > > I plan to continue work on this on Friday and Monday, fixing any > remaining bugs, adding support for the other planar formats and > carefully reviewing if I handle the downsampling correctly. I also > want to add output support for these formats. > > Regards, > > Hans > > On 02/19/2015 03:18 AM, Miguel Casas-Sanchez wrote: > > > > This is the second attempt at creating a patch doing > > that while respecting the pattern movements, crops, > > and other artifacts that can be added to the generated > > frames. > > > > Hope it addresses Hans' comments on the first patch. > > It should create properly moving patterns, border, > > square and noise. SAV/EAV are left out for the new > > formats, but can be pulled in if deemed interesting/ > > necessary. New formats' descriptions are shorter. > > Needless to say, previous formats should work 100% > > the same as before. > > > > Text is, still, printed as Y only. I think the > > goal of the text is not pixel-value-based comparisons, > > but human reading. Please let me know otherwise. > > > > It needed quite some refactoring of the original > > tpg_fillbuffer() function: > > - the internal code generating the video buffer > > line-by-line are factored out into a function > > tpg_fill_oneline(). const added wherever it made > > sense. > > - this new tpg_fill_oneline() is used by both > > new functions tpg_fillbuffer_packed() and > > tpg_fillbuffer_planar(). > > - tpg_fillbuffer_packed() does the non-planar > > formats' buffer composition, so it does, or should > > do, pretty much the same as vivid did before this > > patch. > > > > Tested via both guvcview and qv4l2, checking formats, > > patterns, pattern movements, box and frame checkboxes. > > > > Hope I managed to get the patch correctly into the mail > > i.e. no spurious wraparounds, no whitespaces etc :) > > > > Signed-off-by: Miguel Casas-Sanchez <mcasas@xxxxxxxxxxxx> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
