Hi Laurent, Thanks for the review. On Tue, Feb 24, 2015 at 12:35 AM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Monday 23 February 2015 20:19:32 Lad Prabhakar wrote: >> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> >> >> this patch drops driver specific isp_video_fh, as this >> can be handled by core. > > I'm afraid it's not that simple. > > The omap3isp driver stores video queues per file handle for a reason. This was > design to permit creating a high-resolution still image capture queue and > prepare buffers ahead of time, to avoid the large delay due to cache > management as prepare time when taking the snapshot. > Ah I see the reason. > Now this use case has been partially solved by VIDIOC_CREATE_BUFS, but we're > still missing a VIDIOC_DESTROY_BUFS to make it work completely. That needs to > be solved first. > I haven't used the VIDIOC_CREATE_BUFS ioctl so far in any of the apps so cant comment much on this. But isn't that obvious we need VIDIOC_DESTROY_BUFS or is there any backdoor to destroy them that I am missing ? Regards, --Prabhakar Lad >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> >> --- >> drivers/media/platform/omap3isp/ispvideo.c | 128 ++++++++++--------------- >> drivers/media/platform/omap3isp/ispvideo.h | 13 +-- >> 2 files changed, 49 insertions(+), 92 deletions(-) > > -- > Regards, > > Laurent Pinchart > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
