[RFC PATCH] mn88472: reduce firmware download chunk size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It seems that currently the firmware download on the mn88472 is
somehow wrong for my Astrometa HD-901T2.

Reducing the download chunk size (mn88472_config.i2c_wr_max) to 2 
makes the firmware download consistently succeed.

Any larger value causes the download to always fail:

[    7.671482] mn88472 7-0018: downloading firmware from file 'dvb-demod-mn88472-02.fw'
[    8.206960] mn88472 7-0018: firmware download failed=-32
[    8.208610] rtl2832 7-0010: i2c reg write failed -32
[    8.208620] r820t 8-003a: r820t_write: i2c wr failed=-32 reg=05 len=1: 83
[    8.210459] rtl2832 7-0010: i2c reg write failed -32
[    8.212038] rtl2832 7-0010: i2c reg write failed -32

I'm obviously not too happy about this patch as it slows down the
firmware download but I have not found a way to keep larger chunks in
place and have a working firmware download at the same time.

Signed-off-by: Antti Seppälä <a.seppala@xxxxxxxxx>
---
 drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
index d88f799..3c5c6f9 100644
--- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
+++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
@@ -865,7 +865,7 @@ static int rtl2832u_frontend_attach(struct dvb_usb_adapter *adap)
 			struct mn88472_config mn88472_config = {};
 
 			mn88472_config.fe = &adap->fe[1];
-			mn88472_config.i2c_wr_max = 22,
+			mn88472_config.i2c_wr_max = 2,
 			strlcpy(info.type, "mn88472", I2C_NAME_SIZE);
 			mn88472_config.xtal = 20500000;
 			info.addr = 0x18;
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux