Re: [PATCH 6/7] [media] cx231xx: Improve the media controller comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/18/2015 04:30 PM, Mauro Carvalho Chehab wrote:
> There are two problems at the comment:
> - it is badly idented;
> - its comment doesn't mean anything.
> 
> Fix it.
> 
> Requested-by: Hans Verkuil <hverkuil@xxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
> 
> diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c
> index 634763535d60..87c9e27505f4 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-video.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-video.c
> @@ -714,12 +714,13 @@ static int cx231xx_enable_analog_tuner(struct cx231xx *dev)
>  	if (!mdev)
>  		return 0;
>  
> -/*
> - * This will find the tuner that it is connected into the decoder.
> - * Technically, this is not 100% correct, as the device may be using an
> - * analog input instead of the tuner. However, we can't use the DVB for dvb
> - * while the DMA engine is being used for V4L2.
> - */
> +	/*
> +	 * This will find the tuner that it is connected into the decoder.

s/that it is/that is/

> +	 * Technically, this is not 100% correct, as the device may be
> +	 * using an analog input instead of the tuner. However, as we can't
> +	 * do DVB streaming  while the DMA engine is being used for V4L2,

Two spaces between 'streaming' and 'while'. I know, a nitpick :-)

With those changes:

Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

Regards,

	Hans

> +	 * this should be enough for the actual needs.
> +	 */
>  	media_device_for_each_entity(entity, mdev) {
>  		if (entity->type == MEDIA_ENT_T_V4L2_SUBDEV_DECODER) {
>  			decoder = entity;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux