Hi,
On 09-02-15 16:56, Mauro Carvalho Chehab wrote:
Em Mon, 09 Feb 2015 10:23:48 +0000
Luis de Bethencourt <luis@xxxxxxxxxxxxxxxxx> escreveu:
On Sun, Feb 08, 2015 at 06:07:45PM -0800, Linus Torvalds wrote:
I got this, and it certainly seems relevant,.
It would seem that that whole 'quality' thing needs some range
checking, it should presumably be in the range [1..100] in order to
avoid negative 'sc' values or the divide-by-zero.
Hans, Mauro?
Linus
Hello Linus,
The case of quality being set to 0 is correctly handled in
drivers/media/usb/gspca/jpeg.h [0], so I have sent a patch to do the same
in topro.c.
Patch looks good to me.
I'll double check if some other driver has the same bad handling for
quality set and give a couple days for Hans to take a look.
If he's fine with this approach, I'll add it on a separate pull request.
Luis' patch for this looks good to me and is:
Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Mauro, thanks for picking this one up.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
