Hi Hans, On Tuesday 03 February 2015 16:24:19 Hans Verkuil wrote: > On 02/03/15 16:22, Laurent Pinchart wrote: > > On Monday 02 February 2015 11:09:27 Hans Verkuil wrote: > >> On 02/02/2015 11:01 AM, Laurent Pinchart wrote: > >>> On Sunday 01 February 2015 12:26:11 Guennadi Liakhovetski wrote: > >>>> On a second thought: > >>>> > >>>> On Sun, 1 Feb 2015, Guennadi Liakhovetski wrote: > >>>>> Hi Wills, > >>>>> > >>>>> Thanks for the patch. First and foremost, the title of the patch is > >>>>> wrong. This patch does more than just adding some "adv7604 > >>>>> compatibility." It's adding pad-level API to soc-camera. > >>>>> > >>>>> This is just a rough review. I'm not an expert in media-controller / > >>>>> pad-level API, I hope someone with a better knowledge of those areas > >>>>> will help me reviewing this. > >>>>> > >>>>> Another general comment: it has been discussed since a long time, > >>>>> whether a wrapper wouldn't be desired to enable a seamless use of both > >>>>> subdev drivers using and not using the pad-level API. Maybe it's the > >>>>> right time now?.. > >>>> > >>>> This would be a considerable change and would most probably take a > >>>> rather long time, given how busy everyone is. > >>> > >>> If I understood correctly Hans Verkuil told me over the weekend that he > >>> wanted to address this problem in the near future. Hans, could you > >>> detail your plans ? > >> > >> That's correct. This patch series makes all the necessary changes. > >> > >> https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg83415.html > >> > >> Patches 1-4 have been merged already, but I need to do more testing for > >> the remainder. The Renesas SH7724 board is ideal for that, but > >> unfortunately I can't get it to work with the current kernel. > > > > I can't help you much with that, but I could test changes using the > > rcar-vin driver with the adv7180 if needed (does the adv7180 generate an > > image if no analog source is connected ?). > > I expect so, most SDTV receivers do that. > > > That will need to wait for two weeks though as > > I don't have access to the hardware right now. > > It's certainly appreciated (I'll see if I can rebase it), but I am not > worried about that driver. It's soc_camera that is affected the most. rcar-vin is an soc-camera host driver, isn't it ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html