On 01/27/2015 03:10 PM, Mauro Carvalho Chehab wrote:
Em Tue, 23 Dec 2014 22:48:58 +0200
Antti Palosaari <crope@xxxxxx> escreveu:
Convert driver to kernel I2C model. Old DVB proprietary model is
still left there also.
Signed-off-by: Antti Palosaari <crope@xxxxxx>
+struct rtl2830_platform_data {
+ /*
+ * Clock frequency.
+ * Hz
+ * 4000000, 16000000, 25000000, 28800000
+ */
+ u32 clk;
+
+ /*
+ * Spectrum inversion.
+ */
+ bool spec_inv;
+
+ /*
+ */
+ u8 vtop;
+
+ /*
+ */
+ u8 krf;
+
+ /*
+ */
+ u8 agc_targ_val;
+
+ /*
+ */
+ struct dvb_frontend* (*get_dvb_frontend)(struct i2c_client *);
+ struct i2c_adapter* (*get_i2c_adapter)(struct i2c_client *);
+};
Please fix this to follow the Kernel CodingStyle for struct/function/...
documentation:
Documentation/kernel-doc-nano-HOWTO.txt
Sometimes, I just leave things like that to pass, but the above one is too
ugly, with empty multiple line comments, uncommented arguments, etc.
I added kernel-doc comments for rtl2830, rtl2832 and rtl2832_sdr driver
platform data. PULL request is already updated.
And next time please start keep noise earlier - I have written tens of
these drivers and that was first time you ask kernel-doc format comments
for driver configurations structures. I see those should be as
kernel-doc-nano-HOWTO.txt says, but it was first time I hear about that
rule.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
