Hi Jacek, On Tue, Jan 20, 2015 at 01:53:05PM +0100, Jacek Anaszewski wrote: > On 01/20/2015 12:12 PM, Lee Jones wrote: > >On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > > > >>Add macros for max77693 led part related binding. > >> > >>Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> > >>Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >>Cc: Lee Jones <lee.jones@xxxxxxxxxx> > >>Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > >>--- > >> include/dt-bindings/mfd/max77693.h | 21 +++++++++++++++++++++ > >> 1 file changed, 21 insertions(+) > >> create mode 100644 include/dt-bindings/mfd/max77693.h > >> > >>diff --git a/include/dt-bindings/mfd/max77693.h b/include/dt-bindings/mfd/max77693.h > >>new file mode 100644 > >>index 0000000..f53e197 > >>--- /dev/null > >>+++ b/include/dt-bindings/mfd/max77693.h > >>@@ -0,0 +1,21 @@ > >>+/* > >>+ * This header provides macros for MAX77693 device binding > >>+ * > >>+ * Copyright (C) 2014, Samsung Electronics Co., Ltd. > >>+ * > >>+ * Author: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> > >>+ */ > >>+ > >>+#ifndef __DT_BINDINGS_MAX77693_H__ > >>+#define __DT_BINDINGS_MAX77693_H > >>+ > >>+/* External trigger type */ > >>+#define MAX77693_LED_TRIG_TYPE_EDGE 0 > >>+#define MAX77693_LED_TRIG_TYPE_LEVEL 1 > >>+ > >>+/* Boost modes */ > >>+#define MAX77693_LED_BOOST_OFF 0 > >>+#define MAX77693_LED_BOOST_ADAPTIVE 1 > >>+#define MAX77693_LED_BOOST_FIXED 2 > >>+ > >>+#endif /* __DT_BINDINGS_MAX77693_H */ > > > >These look fairly generic. Do generic LED defines already exist? If > >not, can they? > > I am not entirely sure that they are generic. Different devices > may define different trigger types for low current LEDs and flash > LEDs. Boost modes could also have different semantics. > > Regardless of the above we can consider renaming the file to > include/dt-bindings/leds/max77693.h > > Bryan - what is your opinion? At least trigger type can be chosen for lm3555 (as3645a) as well. I'm not sure about boost mode. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
