Re: [PATCH] reservation: Remove shadowing local variable 'ret'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michel,

On 22 January 2015 at 12:30, Michel Dänzer <michel@xxxxxxxxxxx> wrote:
> From: Michel Dänzer <michel.daenzer@xxxxxxx>
>
> It was causing the return value of fence_is_signaled to be ignored, making
> reservation objects signal too early.
>
Thanks; pushed to my for-next.

> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxx>
> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
> Signed-off-by: Michel Dänzer <michel.daenzer@xxxxxxx>
> ---
>  drivers/dma-buf/reservation.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
> index 3c97c8f..8a37af9 100644
> --- a/drivers/dma-buf/reservation.c
> +++ b/drivers/dma-buf/reservation.c
> @@ -402,8 +402,6 @@ reservation_object_test_signaled_single(struct fence *passed_fence)
>         int ret = 1;
>
>         if (!test_bit(FENCE_FLAG_SIGNALED_BIT, &lfence->flags)) {
> -               int ret;
> -
>                 fence = fence_get_rcu(lfence);
>                 if (!fence)
>                         return -1;
> --
> 2.1.4
>



-- 
Thanks and best regards,
Sumit.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux