Re: [PATCH 01/22] si2168: define symbol rate limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/2014 10:34 PM, Antti Palosaari wrote:
> w_scan complains about missing symbol rate limits:
> This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org
> 
> Chip supports 1 to 7.2 MSymbol/s on DVB-C.
> 
> Signed-off-by: Antti Palosaari <crope@xxxxxx>

Antti,

Are you planning to make a pull request of this patch series?

It looks good to me, so for this patch series:

Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

BTW, please add a cover letter whenever you post a patch series (git send-email --compose).
It makes it easier to get an overview of what the patch series is all about.

Regards,

	Hans

> ---
>  drivers/media/dvb-frontends/si2168.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> index ce9ab44..acf0fc3 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -635,6 +635,8 @@ static const struct dvb_frontend_ops si2168_ops = {
>  	.delsys = {SYS_DVBT, SYS_DVBT2, SYS_DVBC_ANNEX_A},
>  	.info = {
>  		.name = "Silicon Labs Si2168",
> +		.symbol_rate_min = 1000000,
> +		.symbol_rate_max = 7200000,
>  		.caps =	FE_CAN_FEC_1_2 |
>  			FE_CAN_FEC_2_3 |
>  			FE_CAN_FEC_3_4 |
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux