My first code review of the new year, so let's start with a simple one to avoid taxing my brain cells (that are still in vacation mode) too much... On 12/18/2014 05:20 PM, Shuah Khan wrote: > There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() > vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. > > Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Happy New Year! Hans > --- > drivers/media/usb/au0828/au0828-video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c > index 3011ca8..ef49b2e 100644 > --- a/drivers/media/usb/au0828/au0828-video.c > +++ b/drivers/media/usb/au0828/au0828-video.c > @@ -1104,7 +1104,6 @@ static int au0828_set_format(struct au0828_dev *dev, unsigned int cmd, > format->fmt.pix.sizeimage = width * height * 2; > format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; > format->fmt.pix.field = V4L2_FIELD_INTERLACED; > - format->fmt.pix.priv = 0; > > if (cmd == VIDIOC_TRY_FMT) > return 0; > @@ -1189,7 +1188,6 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, > f->fmt.pix.sizeimage = dev->frame_size; > f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; /* NTSC/PAL */ > f->fmt.pix.field = V4L2_FIELD_INTERLACED; > - f->fmt.pix.priv = 0; > return 0; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
