Re: [PATCH] [media] soc_camera: avoid potential null-dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 7, 2015 at 9:44 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> Hi Andy,
>
> Thanks for the patch. Will queue for the next pull request.

If you didn't do that please wait. It seems it has one more place with
similar issue. Moreover, I would like to add a person's name who
reported this.

>
> Regards
> Guennadi
>
> On Wed, 7 Jan 2015, Andy Shevchenko wrote:
>
>> We have to check the pointer before dereferencing it.
>>
>> Signed-off-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>> ---
>>  drivers/media/platform/soc_camera/soc_camera.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c
>> index b3db51c..8c665c4 100644
>> --- a/drivers/media/platform/soc_camera/soc_camera.c
>> +++ b/drivers/media/platform/soc_camera/soc_camera.c
>> @@ -2166,7 +2166,7 @@ static int soc_camera_video_start(struct soc_camera_device *icd)
>>  static int soc_camera_pdrv_probe(struct platform_device *pdev)
>>  {
>>       struct soc_camera_desc *sdesc = pdev->dev.platform_data;
>> -     struct soc_camera_subdev_desc *ssdd = &sdesc->subdev_desc;
>> +     struct soc_camera_subdev_desc *ssdd;
>>       struct soc_camera_device *icd;
>>       int ret;
>>
>> @@ -2177,6 +2177,8 @@ static int soc_camera_pdrv_probe(struct platform_device *pdev)
>>       if (!icd)
>>               return -ENOMEM;
>>
>> +     ssdd = &sdesc->subdev_desc;
>> +
>>       /*
>>        * In the asynchronous case ssdd->num_regulators == 0 yet, so, the below
>>        * regulator allocation is a dummy. They are actually requested by the
>> --
>> 1.8.3.101.g727a46b
>>



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux