Hi Sakari, On Friday 02 January 2015 10:54:41 Sakari Ailus wrote: > On Fri, Jan 02, 2015 at 01:04:16AM +0200, Laurent Pinchart wrote: > > On Thursday 01 January 2015 23:13:54 Sakari Ailus wrote: > > > device_caps in struct v4l2_capability were inadequately set in > > > VIDIOC_QUERYCAP. Fix this. > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx> > > > --- > > > > > > drivers/media/platform/omap3isp/ispvideo.c | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/media/platform/omap3isp/ispvideo.c > > > b/drivers/media/platform/omap3isp/ispvideo.c index cdfec27..d644164 > > > 100644 > > > --- a/drivers/media/platform/omap3isp/ispvideo.c > > > +++ b/drivers/media/platform/omap3isp/ispvideo.c > > > @@ -602,10 +602,13 @@ isp_video_querycap(struct file *file, void *fh, > > > struct v4l2_capability *cap) strlcpy(cap->card, video->video.name, > > > sizeof(cap->card)); > > > > > > strlcpy(cap->bus_info, "media", sizeof(cap->bus_info)); > > > > > > + cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_VIDEO_OUTPUT > > > + | V4L2_CAP_STREAMING | V4L2_CAP_DEVICE_CAPS; > > > > I would align the | under the =. Apart from that, > > > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > I assume you'd apply the patch to your tree eventually? Can you make the > change, or would you prefer me to resend? I can make the change when applying, no need to resend. I'll send a pull request for v3.20. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
