Moikka!
On 12/21/2014 02:06 AM, Benjamin Larsson wrote:
This is what mn88473 support in the mn88472 demod driver could look
like. The code is untested but will look similar in the final version.
It is also possible to let the driver figure out the demod version from
the 0xff register. Then the users would not need to set that parameter.
Same goes to the xtal parameter.
So does the mn88473 support look ok and should the driver figure out
what demod is connected ?
You patch looks rather good and these drivers should be merged to one if
possible, lets say registers are 80% same or something like that. Looks
like those are.
About detecting the chip type. Prefer always detecting automatically be
reading the chip id.
Second best way is to use device ID for that:
static const struct i2c_device_id mn88472_id_table[] = {
{"mn88472", 0},
{"mn88473", 1},
{}
Put the xtal/clock freq to config struct or use clock framework for it
(maybe too heavy solution).
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
