On 12/13/2014 02:35 PM, Antti Palosaari wrote:
Do you understand that code at all?
No I can't really say I understand all the workings of the media api.
Now it is:
FE0 == (fe->id == 0) == RTL2832
FE1 == (fe->id == 1) == MN88472
you changed it to:
FE0 == (fe->id == 0) == MN88472
FE1 == (fe->id == 1) == RTL2832
I thought the rtl2832u_frontend_attach() actually attached the devices.
Then the id's would have followed the frontend.
Then there is:
/* bypass slave demod TS through master demod */
if (fe->id == 1 && onoff) {
ret = rtl2832_enable_external_ts_if(adap->fe[1]);
if (ret)
goto err;
}
After your change that code branch is taken when RTL2832 demod is
activated / used. Shouldn't TS bypass enabled just opposite, when
MN88472 is used....
Antti
This intent of the patch was for better backwards compatibility with old
software. This isn't strictly needed so consider the patch dropped.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
