On 12/12/14 12:07, James Hogan wrote: > Hi Sifan, > > On 11/12/14 20:06, Sifan Naeem wrote: >> Biphase decoding in the current img-ir has got a quirk, where multiple >> Interrupts are generated when an incomplete IR code is received by the >> decoder. >> >> Patch adds a work around for the quirk and enables biphase decoding. >> >> Changes from v1: >> * rebased due to conflict with "img-ir/hw: Fix potential deadlock stopping timer" >> * spinlock taken in img_ir_suspend_timer >> * check for hw->stopping before handling quirks in img_ir_isr_hw >> * new memeber added to img_ir_priv_hw to save irq status over suspend > > For future reference, the list of changes between patchset versions is > usually put after a "---" so that it doesn't get included in the final > git commit message. You can also add any Acked-by/Reviewed-by tags > you've been given to new versions of patchset, assuming nothing > significant has changed in that patch (maintainers generally add > relevant tags for you, that are sent in response to the patches being > applied). > > Anyway, the whole patchset looks okay to me, aside from the one question > I just asked on patch 3 of v1, which I'm not so sure about. I'll let you > decide whether that needs changing since you have the hardware to verify it. > > So for the whole patchset feel free to add my: > Acked-by: James Hogan <james.hogan@xxxxxxxxxx> Mauro: Assuming no other changes are requested in this patchset, do you want these resent with the moving of changelogs out of the main commit messages? Cheers James
Attachment:
signature.asc
Description: OpenPGP digital signature