On Mon, Dec 08, 2014 at 09:19:02AM +0100, Hans de Goede wrote: > Hi, > > On 07-12-14 19:08, Maxime Ripard wrote: > >On Wed, Dec 03, 2014 at 10:49:20AM +0100, Hans de Goede wrote: > > <snip> > > >>So it should not have a simple-bus compatible either, and as such we cannot > >>simply change the mod0 driver from of_clk_define to a platform driver because > >>then we need to instantiate platform devs for the mod0 clock nodes, which > >>means making the clock node a simple-bus. > > > >I guess we can do that as a temporary measure until we get things > >right on that front. I'm totally open to doing that work, so I'm not > >asking you to do it. > > > >>I can see your logic in wanting the ir_clk prcm sub-node to use the > >>mod0 compatible string, so how about we make the mod0 driver both > >>register through of_declare and as a platform driver. Note this means > >>that it will try to bind twice to the ir_clk node, since of_clk_declare > >>will cause it to try and bind there too AFAIK. > > > >Hmmm, I could live with that for a while too. That shouldn't even > >require too much work, since the first thing we check in the mod0 code > >is that we actually have something in reg, which will not be the case > >in the OF_CLK_DECLARE case. > > > >>The of_clk_declare bind will fail though because there is no regs > >>property, so this double bind is not an issue as long as we do not > >>log errors on the first bind failure. > > > >Yep, exactly. > > > >>Note that the ir_clk node will still need an "ir-clk" compatible as > >>well for the MFD to find it and assign the proper resources to it. > > > >No, it really doesn't. At least for now, we have a single mod0 clock > >under the PRCM MFD. If (and only if) one day, we find ourselves in a > >position where we have two mod0 clocks under the PRCM, then we'll fix > >the MFD code to deal with that, because it really should deal with it. > > Ok, using only the mod0 compat string works for me. I'll respin my > patch-set (minus the one patch you've already merged) to make the modo > clk driver use both of_clk_declare and make it a platfrom driver, and > use the mod0 compat string for the ir-clk node. > > Not sure when I'll get this done exactly though, but we still have > a while before 3.20 :) Indeed :) Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
