Re: [PATCH 2/3] mn88472: make sure the private data struct is nulled after free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



But that is not needed anymore ?

regards
Antti

On 12/06/2014 02:25 AM, Benjamin Larsson wrote:
Using this driver with the attach dvb model might trigger a use
after free when unloading the driver. With this change the driver
will always fail on unload instead of randomly crash depending
on if the memory has been reused or not.

Signed-off-by: Benjamin Larsson <benjamin@xxxxxxxxxxxx>
---
  drivers/staging/media/mn88472/mn88472.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
index 36ef39b..a9d5f0a 100644
--- a/drivers/staging/media/mn88472/mn88472.c
+++ b/drivers/staging/media/mn88472/mn88472.c
@@ -489,6 +489,7 @@ static int mn88472_remove(struct i2c_client *client)

  	regmap_exit(dev->regmap[0]);

+	memset(dev, 0, sizeof(*dev));
  	kfree(dev);

  	return 0;


--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux