Hi Laurent, On 01/12/14 21:13, Laurent Pinchart wrote: > The function fills a link data structure with the device node and port > number at both the local and remote ends of a link defined by one of its > endpoint nodes. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > --- > drivers/media/v4l2-core/v4l2-of.c | 61 +++++++++++++++++++++++++++++++++++++++ > include/media/v4l2-of.h | 27 +++++++++++++++++ > 2 files changed, 88 insertions(+) > > Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c > index b4ed9a9..c473479 100644 > --- a/drivers/media/v4l2-core/v4l2-of.c > +++ b/drivers/media/v4l2-core/v4l2-of.c > @@ -142,3 +142,64 @@ int v4l2_of_parse_endpoint(const struct device_node *node, > return 0; > } > EXPORT_SYMBOL(v4l2_of_parse_endpoint); > + > +/** > + * v4l2_of_parse_link() - parse a link between two endpoints > + * @node: pointer to the endpoint at the local end of the link > + * @link: pointer to the V4L2 OF link data structure > + * > + * Fill the link structure with the local and remote nodes and port numbers. > + * The local_node and remote_node fields are set to point to the local and > + * remote port parent nodes respectively (the port parent node being the parent Not sure it that improves anything, but how about changing "remote port parent" to "remote port's parent" ? I took me a while to understand this whole sentence. Anyway the patch looks good to me. Acked-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > + * node of the port node if that node isn't a 'ports' node, or the grand-parent > + * node of the port node otherwise). > + * > + * A reference is taken to both the local and remote nodes, the caller must use > + * v4l2_of_put_link() to drop the references when done with the link. > + * > + * Return: 0 on success, or -ENOLINK if the remote endpoint can't be found. > + */ -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
