Hi! > >How are faults cleared? Should it be list of strings, instead of > >bitmask? We may want to add new fault modes in future... > > Faults are cleared by reading the attribute. I will add this note. > There can be more than one fault at a time. I think that the bitmask > is a flexible solution. I don't see any troubles related to adding > new fault modes in the future, do you? I do not think that "read attribute to clear" is good idea. Normally, you'd want the error attribute world-readable, but you don't want non-root users to clear the errors. I am not sure if bitmask is good solution. I'd return space-separated strings like "overtemp". That way, there's good chance that other LED drivers would be able to use similar interface... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
