On Wed, Nov 26, 2014 at 10:26 AM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxxxxxxx> wrote:
> As reported by smatch:
> drivers/media/tuners/tda18271-common.c:176 tda18271_read_extended() warn: if statement not indented
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
>
> diff --git a/drivers/media/tuners/tda18271-common.c b/drivers/media/tuners/tda18271-common.c
> index 86e5e3110118..6118203543ea 100644
> --- a/drivers/media/tuners/tda18271-common.c
> +++ b/drivers/media/tuners/tda18271-common.c
> @@ -173,12 +173,9 @@ int tda18271_read_extended(struct dvb_frontend *fe)
>
> for (i = 0; i < TDA18271_NUM_REGS; i++) {
> /* don't update write-only registers */
> - if ((i != R_EB9) &&
> - (i != R_EB16) &&
> - (i != R_EB17) &&
> - (i != R_EB19) &&
> - (i != R_EB20))
> - regs[i] = regdump[i];
> + if ((i != R_EB9) && (i != R_EB16) && (i != R_EB17) &&
> + (i != R_EB19) && (i != R_EB20))
> + regs[i] = regdump[i];
> }
>
> if (tda18271_debug & DBG_REG)
> --
> 1.9.3
>
Mauro,
I would actually rather NOT merge this patch. This hurts the
readability of the code. If applied already, please revert it.
Cheers,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
