Hi Hans, On Tue, Nov 18, 2014 at 09:56:00AM +0100, Hans Verkuil wrote: > Hi Sakari, > > A few notes: > > Typo in subject: intput -> input Will fix. > On 11/18/14 06:40, Sakari Ailus wrote: > > Add input and output capability flags for setting native size of the device, > > and document them. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx> > > --- > > Documentation/DocBook/media/v4l/vidioc-enuminput.xml | 8 ++++++++ > > Documentation/DocBook/media/v4l/vidioc-enumoutput.xml | 8 ++++++++ > > include/uapi/linux/videodev2.h | 2 ++ > > 3 files changed, 18 insertions(+) > > > > diff --git a/Documentation/DocBook/media/v4l/vidioc-enuminput.xml b/Documentation/DocBook/media/v4l/vidioc-enuminput.xml > > index 493a39a..603fece 100644 > > --- a/Documentation/DocBook/media/v4l/vidioc-enuminput.xml > > +++ b/Documentation/DocBook/media/v4l/vidioc-enuminput.xml > > @@ -287,6 +287,14 @@ input/output interface to linux-media@xxxxxxxxxxxxxxx on 19 Oct 2009. > > <entry>0x00000004</entry> > > <entry>This input supports setting the TV standard by using VIDIOC_S_STD.</entry> > > </row> > > + <row> > > + <entry><constant>V4L2_IN_CAP_NATIVE_SIZE</constant></entry> > > + <entry>0x00000008</entry> > > + <entry>This input supports setting the native size using > > + the <constant>V4L2_SEL_TGT_NATIVE_SIZE</constant> > > + selection target, see <xref > > + linkend="v4l2-selections-common"/>.</entry> > > + </row> > > I would expand on this a little bit (or alternatively add that to the > V4L2_SEL_TGT_NATIVE_SIZE documentation itself, at your discretion): I think I'd prefer having this in the selection target documentation, as that's something which involves this flag, not so much the capability flags. > > "Setting the native size will generally only make sense for memory > to memory devices where the software can create a canvas of a given > size in which for example a video frame can be composed. In that case > V4L2_SEL_TGT_NATIVE_SIZE can be used to configure the size of that > canvas." I'll use the text as-is. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
