Hi Jonathan, On Tue, Nov 18, 2014 at 1:03 PM, Jonathan Corbet <corbet@xxxxxxx> wrote: > On Tue, 18 Nov 2014 11:23:35 +0000 > "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> wrote: > >> drivers/media/platform/marvell-ccic/mcam-core.c | 29 +++++-------------------- >> 1 file changed, 5 insertions(+), 24 deletions(-) > > So I'm not convinced that this patch improves things; it moves a tiny bit > of code into another file where anybody reading the driver will have to > go look to see what's going on. But I guess it doesn't really make > things worse either; I won't try to stand in its way. It would be nice > to see a real changelog on the patch, though. > Sorry there is no movement of code to other file. And I dont see any reason why anybody reading will go haywire its a standard v4l2 thing. The subject explains it all, If you still want me to elaborate I can post a v2. Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html