Re: [PATCH v2 1/1] media: Print information on failed link validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On Wed, Oct 29, 2014 at 01:20:06AM +0200, Laurent Pinchart wrote:
> >  			ret = -EPIPE;
> > +			dev_dbg(entity->parent->dev,
> > +				"\"%s\":%u must be connected by an enabled link, error %d\n",
> > +				entity->name,
> > +				find_first_zero_bit(active, entity->num_pads),
> > +				ret);
> 
> Given that ret is always set to -EPIPE, I wouldn't print ", error %d".
> 
> Apart from that,
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Thanks for the ack. Good point as well, I'll fix that for v3.

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux