Hi Srini, Sorry seems I never replied to this. > >>drivers/media/rc/st_rc.c:281:15: warning: assignment makes pointer > >>from integer without a cast [enabled by default] > >> rc_dev->rstc = reset_control_get(dev, NULL); > > > >Is managing the reset line actually optional though? I can't test atm as I don't have > >access to my board, but quite often if the IP's aren't taken out of reset reads / writes > >to the perhpiheral will hang the SoC. > > > Yes and No. > AFAIK reset line is optional on SOCs like 7108, 7141. > I think having the driver function without reset might is a value > add in case we plan to reuse the mainline driver for these SOCs. Yes that is a good point, for the series: - Acked-by: Peter Griffin <peter.griffin@xxxxxxxxxx> regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
