On Tue, Oct 14, 2014 at 04:57:53PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 10/14/2014 10:26 AM, Yoshihiro Kaneko wrote:
>
> >From: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
>
> >The scaling function had been forbidden for the capture format of
> >NV16 until now. With this patch, a horizontal scaling-up function
> >is supported to the capture format of NV16. a vertical scaling-up
> >by the capture format of NV16 is forbidden for the H/W specification.
>
> s/for/by/?
>
How about the following text?
Up until now scaling has been forbidden for the NV16 capture format. This
patch adds support for horizontal scaling-up for NV16. Vertical scaling-up
for NV16 is forbidden for by the H/W specification.
> >Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
> >Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
> >---
> > drivers/media/platform/soc_camera/rcar_vin.c | 19 +++++++++++++++----
> > 1 file changed, 15 insertions(+), 4 deletions(-)
>
> >diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> >index 00bc98d..bf3588f 100644
> >--- a/drivers/media/platform/soc_camera/rcar_vin.c
> >+++ b/drivers/media/platform/soc_camera/rcar_vin.c
> [...]
> >@@ -1622,9 +1622,19 @@ static int rcar_vin_set_fmt(struct soc_camera_device *icd,
> > if (priv->error_flag == false)
> > priv->error_flag = true;
> > else {
> >- if ((pixfmt == V4L2_PIX_FMT_NV16) && (pix->width & 0x1F)) {
> >- dev_err(icd->parent, "Specified width error in NV16 format.\n");
> >- return -EINVAL;
> >+ if (pixfmt == V4L2_PIX_FMT_NV16) {
> >+ if (pix->width & 0x1F) {
> >+ dev_err(icd->parent,
> >+ "Specified width error in NV16 format. "
>
> You should indent the string more to the right, preferrably starting it
> under 'icd'.
>
> >+ "Please specify the multiple of 32.\n");
>
> Do not break the string like this. scripts/checkpatch.pl has been taught
> to not complain about long strings.
>
> >+ return -EINVAL;
> >+ }
> >+ if (pix->height != cam->height) {
> >+ dev_err(icd->parent,
> >+ "Vertical scaling-up error in NV16 format. "
> >+ "Please specify input height size.\n");
>
> Same here. Not breaking the lines helps to find the error messages in the
> code.
>
> [...]
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
