Hi Kaneko-san, Matsuoka-san,
On Tue, Oct 14, 2014 at 8:26 AM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
> From: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
Thanks for our patch!
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -120,6 +144,326 @@ enum chip_id {
> RCAR_E1,
> };
>
> +struct VIN_COEFF {
Please don't use upper case for struct names.
> + unsigned short xs_value;
> + unsigned long coeff_set[24];
The actual size of "long" depends on the word size of the CPU.
On 32-bit builds it is 32-bit, on 64-bit builds it is 64-bit.
As all values in the table below are 32-bit, and the values are
written to register using iowrite32(), please use "u32" instead of
"unsigned long".
> +};
> +#define VIN_COEFF_SET_COUNT (sizeof(vin_coeff_set) / sizeof(struct VIN_COEFF))
There exists a convenience macro "ARRAY_SIZE()" for this.
Please just use "ARRAY_SIZE(vin_coeff_set)" instead of defining
"VIN_COEFF_SET_COUNT".
> @@ -677,6 +1024,61 @@ static void rcar_vin_clock_stop(struct soc_camera_host *ici)
> /* VIN does not have "mclk" */
> }
>
> +static void set_coeff(struct rcar_vin_priv *priv, unsigned long xs)
I think xs can be "unsigned short"?
> +{
> + int i;
> + struct VIN_COEFF *p_prev_set = NULL;
> + struct VIN_COEFF *p_set = NULL;
If you add "const" to the two definitions above...
> + /* Search the correspondence coefficient values */
> + for (i = 0; i < VIN_COEFF_SET_COUNT; i++) {
> + p_prev_set = p_set;
> + p_set = (struct VIN_COEFF *) &vin_coeff_set[i];
... the above cast is no longer needed.
> @@ -686,6 +1088,7 @@ static int rcar_vin_set_rect(struct soc_camera_device *icd)
> unsigned int left_offset, top_offset;
> unsigned char dsize = 0;
> struct v4l2_rect *cam_subrect = &cam->subrect;
> + unsigned long value;
"u32", as it's written to a 32-bit register later.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
