On Thu, Oct 2, 2014 at 9:21 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > If power management is disabled these function become unused, so there > is no reason to build them. This fixes a couple of build warnings when > PM(_SLEEP,_RUNTIME) is not enabled. Thanks! Despite the availability of your patch, this build warning has migrated to mainline. > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c > @@ -2681,7 +2682,9 @@ static int s5p_jpeg_runtime_resume(struct device *dev) > > return 0; > } > +#endif I'd add a comment "/* CONFIG_PM_RUNTIME || CONFIG_PM_SLEEP */" here, as above is a big block of code. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html