Em Fri, 10 Oct 2014 03:11:32 +0900
Akihiro TSUKADA <tskd08@xxxxxxxxx> escreveu:
> On 2014年10月09日 01:04, Mauro Carvalho Chehab wrote:
> >> @@ -251,6 +251,16 @@ static int run_scan(struct arguments *args,
> >> if (dvb_retrieve_entry_prop(entry, DTV_POLARIZATION, &pol))
> >> pol = POLARIZATION_OFF;
> >>
> >> + if (parms->current_sys == SYS_ISDBS) {
> >> + uint32_t tsid = 0;
> >> +
> >> + dvb_store_entry_prop(entry, DTV_POLARIZATION, POLARIZATION_R);
> >> +
> >> + dvb_retrieve_entry_prop(entry, DTV_STREAM_ID, &tsid);
> >> + if (!dvb_new_ts_is_needed(dvb_file->first_entry, entry,
> >> + freq, shift, tsid))
> >> + continue;
> >
> > This is likely needed for DVB-T2 and DVB-S2 too.
>
> Should we compare channel entries by (freq, stream_id, polarization) triplet
> instead of by the current (freq, polarization) or (freq, stream_id)?
For DVB-S2, it should likely be (freq, stream_id, polarization) triplet
(tests needed).
For DVB-T2, (freq, stream_id) pair should work;
For ISDB-S, you likely need the (freq, stream_id, polarization) triplet
too, as you may have two polarizations there, right?
> >> @@ -258,6 +268,10 @@ static int run_scan(struct arguments *args,
> >> count++;
> >> dvb_log("Scanning frequency #%d %d", count, freq);
> >>
> >> + if (!args->lnb_name && entry->lnb &&
> >> + (!parms->lnb || strcasecmp(entry->lnb, parms->lnb->alias)))
> >
> > Shouldn't it be: !strcasecmp(entry->lnb, parms->lnb->alias)? Or maybe just
> > remove this test.
> I want to update parms->lnb (which was set from the prev entry)
> only if it differs from entry->lnb (current one),
> and don't want to linear-search all LNB types for every entries,
> as lots of entries are expected to have the same LNB types.
Ah, ok. Please add a comment then.
> --
> akihiro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
