Re: Tevii S480 on Unicable SCR System

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 08.10.2014 um 20:00 schrieb Mauro Carvalho Chehab:
> Em Wed, 08 Oct 2014 18:52:09 +0200
> Ulrich Eckhardt <uli-lirc@xxxxxxxxxxxxxxx> escreveu:
>>  
>>         /*
>> +        * Ensure that frontend voltage is switched off on initialization
>> +        */
>> +       if (dvb_powerdown_on_sleep) {
> 
> I'm wandering why to test if (dvb_powerdown_on_sleep) here...
> 
> MODULE_PARM_DESC(dvb_powerdown_on_sleep, "0: do not power down, 1: turn LNB voltage off on sleep (default)");
> 
> That controls what happens when the frontend's thread stops, and not
> what happens during device initialization.
> So, IMHO, it doesn't apply here.

OK, I agree.

> My vote is to fix it at the driver's level.

So if no other opinions turns up the next days and this problem occurs only on 
the Tevii card, I will reformat my patch in my first E-Mail correctly for 
submission. 
 
Best Regards
Uli
-- 
Ulrich Eckhardt                  http://www.uli-eckhardt.de

Ein Blitzableiter auf dem Kirchturm ist das denkbar stärkste 
Misstrauensvotum gegen den lieben Gott. (Karl Krauss)
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux