Re: [PATCH V3 04/13] cx231xx: give each master i2c bus a seperate name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/02/2014 08:20 AM, Matthias Schwarzott wrote:
V2: Use snprintf to construct the complete name

Signed-off-by: Matthias Schwarzott <zzam@xxxxxxxxxx>
---
  drivers/media/usb/cx231xx/cx231xx-i2c.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c
index a30d400..b10f482 100644
--- a/drivers/media/usb/cx231xx/cx231xx-i2c.c
+++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c
@@ -506,13 +506,14 @@ void cx231xx_do_i2c_scan(struct cx231xx *dev, int i2c_port)
  int cx231xx_i2c_register(struct cx231xx_i2c *bus)
  {
  	struct cx231xx *dev = bus->dev;
+	char bus_name[3];

you don't need that variable anymore :]


  	BUG_ON(!dev->cx231xx_send_usb_command);

  	bus->i2c_adap = cx231xx_adap_template;
  	bus->i2c_adap.dev.parent = &dev->udev->dev;

-	strlcpy(bus->i2c_adap.name, bus->dev->name, sizeof(bus->i2c_adap.name));
+	snprintf(bus->i2c_adap.name, sizeof(bus->i2c_adap.name), "%s-%d", bus->dev->name, bus->nr);

  	bus->i2c_adap.algo_data = bus;
  	i2c_set_adapdata(&bus->i2c_adap, &dev->v4l2_dev);


With a correction for small mistake I mentioned:
Reviewed-by: Antti Palosaari <crope@xxxxxx>

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux