On 09/30/14 11:57, Philipp Zabel wrote: > Hi, > > These patches add JPEG encoding and decoding support for CODA7541 (i.MX5). > The encoder video device is split into one video device per codec, so that > each video device can register only the relevant controls. The H.264/MPEG4 > decoder is kept as one video device, but the JPEG decoder video device is > separate because it supports more uncompressed formats (currently YUV422P, > in the future grayscale or YUV 4:4:4 support could be added). Normally device nodes are linked to DMA engines, so the only reason why you would have e.g. two video nodes is if you can capture from both at the same time. Is that the case here as well? If not, then it really should be a single video node. That not all controls are relevant for the currently chosen codec is not important. Are there other reasons than the controls to split it up into multiple video devices? Regards, Hans > > regards > Philipp > > Philipp Zabel (10): > [media] coda: add support for planar YCbCr 4:2:2 (YUV422P) format > [media] coda: identify platform device earlier > [media] coda: add coda_video_device descriptors > [media] coda: split out encoder control setup to specify controls per > video device > [media] coda: add JPEG register definitions for CODA7541 > [media] coda: add CODA7541 JPEG support > [media] coda: store bitstream buffer position with buffer metadata > [media] coda: pad input stream for JPEG decoder > [media] coda: try to only queue a single JPEG into the bitstream > [media] coda: allow userspace to set compressed buffer size in a > certain range > > drivers/media/platform/coda/Makefile | 2 +- > drivers/media/platform/coda/coda-bit.c | 204 +++++++--- > drivers/media/platform/coda/coda-common.c | 608 +++++++++++++++++++----------- > drivers/media/platform/coda/coda-jpeg.c | 225 +++++++++++ > drivers/media/platform/coda/coda.h | 21 +- > drivers/media/platform/coda/coda_regs.h | 7 + > 6 files changed, 785 insertions(+), 282 deletions(-) > create mode 100644 drivers/media/platform/coda/coda-jpeg.c > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
