On Tue, Sep 30, 2014 at 09:37:57AM +0200, Boris Brezillon wrote: > On Mon, 29 Sep 2014 23:41:09 +0300 > Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: [...] > > Incidentally, patch 2/5 in this series is missing a documentation update ;-) > > Yep, regarding this patch, I wonder if it's really necessary to add > new formats to the v4l2_mbus_pixelcode enum. > If we want to move to this new common definition (across the video > related subsytems), we should deprecate the old enum > v4l2_mbus_pixelcode, and this start by not adding new formats, don't > you think ? I agree in general, but I think it could prove problematic in practice. If somebody wants to use one of the new codes but is using the V4L2 enum they have a problem. That said, given that there is now a unified enum people will hopefully start converting drivers to it instead. Thierry
Attachment:
pgpQv2kGEi3Zh.pgp
Description: PGP signature
